Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CodeMetrics output writer to handle null source tree for non-sour… #2350

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Fix CodeMetrics output writer to handle null source tree for non-sour… #2350

merged 1 commit into from
Apr 17, 2019

Conversation

mavasani
Copy link
Contributor

…ce locations

Fixes #2242

@mavasani mavasani requested review from genlu, sharwell and a team April 16, 2019 22:16
@sharwell
Copy link
Member

Do we have tests for this package?

@mavasani
Copy link
Contributor Author

We have tests for the core code metrics computation: https://github.com/dotnet/roslyn-analyzers/blob/master/src/Microsoft.CodeQuality.Analyzers/UnitTests/Maintainability/CodeMetricsComputationTests.cs, but not for the code metrics output writer. The writer was ported as-is from the legacy code metrics code base in VSO repo.

@mavasani mavasani merged commit 0c3907f into dotnet:master Apr 17, 2019
@mavasani mavasani deleted the CodeMetricsBugFix branch April 17, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

@genlu genlu Awaiting requested review from genlu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics.MetricsOutputWriter null reference exception on vb.net projects
2 participants
@mavasani @sharwell